Skip to content

Fix ZeroDivisionError for inverse unit conversions#159161

Merged
joostlek merged 5 commits into
home-assistant:devfrom
ReneNulschDE:fix-unit-conversion
Dec 23, 2025
Merged

Fix ZeroDivisionError for inverse unit conversions#159161
joostlek merged 5 commits into
home-assistant:devfrom
ReneNulschDE:fix-unit-conversion

Conversation

@ReneNulschDE
Copy link
Copy Markdown
Contributor

Breaking change

Proposed change

Add a zero guard to inverse unit conversions in homeassistant.util.unit_conversion so a zero input no longer triggers a ZeroDivisionError. This fixes the zero-value energy distance scenario described in the issue #159036
Addresses the failing tests/util/test_unit_conversion.py case covering 0 KWh/100km → km/kWh.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Comment thread homeassistant/util/unit_conversion.py Outdated
Comment thread homeassistant/util/unit_conversion.py Outdated
@MartinHjelmare MartinHjelmare changed the title Fix: Add zero-guard for inverse unit conversions to prevent ZeroDivisionError Fix ZeroDivisionError for inverse unit conversions Dec 16, 2025
@joostlek joostlek added this to the 2025.12.5 milestone Dec 23, 2025
@joostlek joostlek merged commit 19f8d9d into home-assistant:dev Dec 23, 2025
66 checks passed
@ReneNulschDE ReneNulschDE deleted the fix-unit-conversion branch December 23, 2025 20:30
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Core - unit_conversion.py - inverse conversion causes ZeroDivisionError after unit change

5 participants